Repository navigation
feat: k×s evaluation/convolution coupling - #363
Merged
Merged
Conversation
Adaptive evaluation now composes with oversampled PSF convolution: each
pixel evaluated at k_i * s is partially binned (mean per (k_i)^2 group) to
the uniform s the Convolver requires.
- over_sample_util.convolve_bin_segment_ids_from +
binned_to_convolve_size_from (numpy bincount / jax segment_sum, trailing
dims, identity fast path when all sizes equal s, divisibility guard).
- Imaging validation relaxes from equality to divisibility (adaptive
Array2D legal when every entry % s == 0).
- Mapper.mapping_matrix_over_sampled_for(s): k x s for pixelizations via
direct scatter — parents are fine-cell segment ids with fractions
1/k_i^2, so the k_i*s-resolution intermediate is never materialised;
exact by linearity (fold of folds = full fold, tested to 1e-14). The 2b
property delegates to it with k=1.
- Inversion routes the psf's s to the mapper.
Tests pinned to the phase-1 adaptive ground truth (library reproduces the
brute-force k in {2,1} reference exactly); guard tests updated from the
equality rule to divisibility.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements phase 2 of the k×s coupling (#362, design
kxs_design.mdapproved): adaptive evaluation over-sampling now composes with oversampled PSF convolution — evaluate at per-pixel k_i·s, partially bin to the uniform s the Convolver requires, convolve, bin to image resolution.binned_to_convolve_size_from+convolve_bin_segment_ids_from(bincount/segment_sum, trailing dims, identity fast path, divisibility guard).Imagingvalidation relaxes equality → divisibility (adaptive Array2D legal when every entry % s == 0 — the one intentional behaviour change; guard tests updated).Mapper.mapping_matrix_over_sampled_for(s)— exact by linearity, built by direct scatter (fine-cell segment parents, 1/k² fractions), memory independent of k; 2b property = k=1 case, bit-for-bit.Tests pinned to the phase-1 adaptive ground truth (exact); suites 863/946/336. Companion PyAutoGalaxy PR carries the call sites.
🤖 Generated with Claude Code